Fix homepage carousel explicit tab selection#7
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: pa7ch3s <Pa7ch3s@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and Impact
The homepage Core Areas carousel could overwrite an explicit click or keyboard selection after
scrollIntoView()settled. At common viewport widths, selectingAI Penetration TestingshowedThick Clients, and selectingThick ClientsshowedWeb3 / Blockchain Security, causing a significant user-facing correctness break in the primary homepage interaction.Root Cause
The debounced passive scroll-sync handler treated the browser scroll generated by our own
scrollIntoView()call as user scrolling, recomputed the active tab from the carousel center, and replaced the explicit selection with a neighboring tab when the selected tab could not be centered at scroll extents.Fix
Suppress scroll-sync while programmatic carousel scrolling is in progress and initialize the carousel state without forcing a synthetic scroll.
Validation
_blankrel safety, and#focusPanelvisibility.